search

SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

Add bilge and generator groups, plus a few other additions #577

Closed ba58smith closed 3 years ago

ba58smith commented 3 years ago

As per a fair bit of discusson on Slack, and then the opportunity for people to review this document: https://docs.google.com/document/d/1FW3RwhahgAzaG13bGoRHMMmVs8gQmURWIhO6yDZe6w8/edit?ts=5ef4496a#heading=h.z2u4xo2bbl8m

I have NOT been able to test the JSON. Long story, but I just can't. So for sure, someone needs to try these new and changed files to make sure they generate the correct HTML.

ba58smith commented 3 years ago

I will try to figure out how to split a PR into 3 separate PR's.

I will look at the test data to see if I can understand what it is I should be adding. JSON is all very new to me - this PR, in fact.

I will see if there are opportunities for shared definitions, although I think the only things I copy-pasted were those electrical items you mentioned.

And I'll try to run the test on my Pi.

ba58smith commented 3 years ago

@tkurki - I think the best way for me to split this PR into smaller ones is to simply remove this one, and I'll start over. (I have all the changes saved elsewhere, so I won't lose any work.) Do you agree? Should I just "Close and comment"? (Or maybe you have to do it - I may not have the necessary rights to do it.)

tkurki commented 3 years ago

Agree! You can close your own pr, but closing it now.