search

SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

Add generator as a new top level #584

Closed ba58smith closed 1 year ago

ba58smith commented 3 years ago

per @tkurki, moved common electrical properties out of /groups/electrical.json into definitions.json.

then, created /groups/generator.json, along with valid test data.

npm test fails with: AssertionError: There should be no missing schema uris, but found https://signalk.org/specification/1.0.0/schemas/groups/generator.json: expected [ Array(1) ] to have a length of 0 but got 1 @tkurki said to submit the PR with this, and that he would investigate.

tkurki commented 3 years ago

New schema files need to be added also here: https://github.com/SignalK/specification/blob/master/src/index.js#L22-L35

ba58smith commented 3 years ago

@tkurki - OK. But I'm now away from the boat, and my Pi, for three weeks. I can fix this when I return, or you can make that change (for this PR, and for the new Bilge top level PR), so you can merge the result.

ba58smith commented 3 years ago

@turki, I added the new files where you said to add them (in your comment above), but still, it fails the test, and I have no idea why.