search

SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

Add "arrivalCircle" to "nextPoint" #628

Open panaaj opened 2 years ago

panaaj commented 2 years ago

Addition of arrivalCircle to nextPoint to allow an arrival alarm to be implemented.

panaaj commented 2 years ago

Added tests for nextPoint.arrivalCircle. I have noticed two things in the test data that don't align with the text in the proposed CourseAPI.

  1. href test value is under vessels ("href": "/vessels/vessels.urn:mrn:imo:mmsi:230099999/resources/waypoints/...") when in practice resources is at the root of ./signalk/v1/api.
  2. arrivalCircleEntered notification is defined as notifications.arrivalCircleEntered where the proposed notification path in the Course API PR is notifications.navigation.course.arrivalCircleEntered

Should these be updated in the test file?

tkurki commented 2 years ago

I'll merge this, submit a new PR for fixes?

tkurki commented 2 years ago

Oh, please rebase. Would do it myself nicely if the branch were under this repo ;-)