Open godind opened 2 months ago
Can you write a larger summary of the changes? Really hard to parse and make sense of the diffs.
Diff ignoring whitespace changes is better https://github.com/SignalK/specification/pull/664/files?w=1
There was no squash commit for some unknown reason.
Maybe read from my fork here: https://github.com/godind/specification/tree/Zones-meta/mdbook/src
Not sure how else to do it but pasting the whole thing here. Or I could create another branch with a single commit.
The PR is based on that branch so there is no difference whether you look at the PR or the branch.
If you don't squash then there is no squash, just your commits.
But in terms of understanding what has changed squashing or the long list of commits with less than understandable commit messages is not the problem. You have made so many changes to line breaks without changing the content that it is needlessly hard to understand what are the meaningful changes. This is what Scott is asking - the PR description is pretty cryptic. So please can you summarise how and why this PR changes things?
What do you suggest to fix this? I'm not sure how I can resubmit in one change without line breaks. I formatted so I could read myself.
It's a learning curve.
Thanks
So please can you summarise how and why this PR changes things?
"values": [ { "path": "notifications.mob", "value": null } ]
to sending an update the notification path with normal state and an empty method:
"value": { "message": "", "state": "normal", "method": [] }
sound
from the method array values. Resolve, update notification by setting state to normal
.Please read the output as this is my first spec update. I wrote this based on my exchange with Scott and what I understood. I'm not without fault...
I hope what I wrote helps!
Update to change ffrom alarm to notification. Adjusted zones and operationnal concept.