search

SignalK / vedirect-serial-usb

18 stars 14 forks source link

feature: multiple devices #32

Closed KEGustafsson closed 3 years ago

KEGustafsson commented 3 years ago

This PR brings a support to multiple concurrent connections, address issue #29. Connections can be over serial, udp or tcp. Tested now with one tcp and multiple udp connection concurrently and working OK. Serial connection is not tested. I have my MPPT converter on boat (tcp link), so I was not able to do it by myself. So help would be appreciated a lot.

@joabakk, @tkurki, @sbender9. Can you review the proposed changes and give comments if this is anywhere near ready to be merged?

KEGustafsson commented 3 years ago

@joabakk Please check if README is OK. If yes, then ready on my side.

KEGustafsson commented 3 years ago

@joabakk, @tkurki, @sbender9 I came up a migration solution based on npm postinstall script. Is this OK? I have tested all old config scenarios and this is working well. And after installation reboot is anyway required and then the new script is not causing any issues.