search

Signalen / backend

Backend for Signalen, an application that helps cities manage and prioritize nuisance reports.
https://signalen.org
Mozilla Public License 2.0
5 stars 5 forks source link

FO: Sorting on "Wijk" does not work #166

Open someren opened 2 years ago

someren commented 2 years ago

BE version 2.3.2 FE version 1.68.0

I created a filter based on status + districts. Then used sorting to alphabetically sort on "Stadsdeel". The result is incorrect. The disctricts are not sorted correctly. For example: Empel should be listed above Engelen and disctrict Noord appears in the middle and end of this list image

Could you please fix this issue?

Possibly related to #165

someren commented 2 years ago

Getest op versie 2.4.1. issue speelt nog steeds.

tcoenen commented 2 years ago

This sorting is hardcoded to use the stadsdeel field on the Location model. That field is only filled for the original Signalen instance in Amsterdam and sorting for area never worked for VNG installations. We need a more general approach than filling the stadsdeel field.

tcoenen commented 2 years ago

Backend implementation is now awaiting review in Amsterdam. Note that the frontend will still have to implement some changes as well.

tcoenen commented 2 years ago

Backend was approved and merged. Will be available on acceptatie likely later today.

someren commented 2 years ago

Getest op versie 2.5. Issue is nog niet opgelost.

boris-arkenaar commented 2 years ago

Dit vereist nog werk in de frontend

bartjkdp commented 2 years ago

Getest met frontend v2.6.2 en backend 2.7.1. Het lijkt een beetje te werken, maar niet echt:

image

Call naar de backend is:

GET https://api.melding.acc.heerlen.nl/signals/v1/private/signals/?page=1&ordering=area_name&page_size=50
bartjkdp commented 2 years ago

Lijkt wel te werken op productie, zou misschien iets omgeving-specifieks kunnen zijn van de acceptatieomgeving. Misschien iets met meerdere AreaTypes? Ik duik er nog even in.

boris-arkenaar commented 2 years ago

In een omgeving waar niet altijd met areas gewerkt is zal het niet (volledig) werken.