Refactor Django Rest Framework (DRF)

Signalen / backend

Backend for Signalen, an application that helps cities manage and prioritize nuisance reports.

https://signalen.org

Mozilla Public License 2.0

5 stars 5 forks source link

Refactor Django Rest Framework (DRF) #7

Closed bartjkdp closed 4 years ago

bartjkdp commented 4 years ago

Original by @CBuiVNG

Currently DRF has too many responsibilities. It includes auth, data serialization, partial business logic, data persistence. We should refactor this to separate layers.

serialization with dataclass (using pydantic or similar. Validation should then be place at these objects)
per object auth checks in the views. Move these out of DRF
extract business logic (from DRF, FAT django models) to separate service layer (service layer)
try to avoid using FAT models if possible

spreeker commented 4 years ago

Drf_amsterdam module was made by me. It would be trivial to create a drf_vngr one.

With like blue colors and a vng look.

CBuiVNG commented 4 years ago

On hold for now, will be postponed and implemented later