Closed ginokok1996 closed 3 years ago
@ginokok1996 currently this is a read-only repository. It would be great if you can open this Pull Request at Amsterdam/signalen-frontend. This repository will be synced periodically with Amsterdam/signals-frontend.
@ginokok1996 currently this is a read-only repository. It would be great if you can open this Pull Request at Amsterdam/signalen-frontend. This repository will be synced periodically with Amsterdam/signals-frontend.
I'll edit the publiccode with the suggestions. Then ill open this pull request at the Amsterdam/signalen-frontend.
@ginokok1996 I'm sorry for diving into the nitpicking before stating I am really happy to see this PR! I got a bit carried away :) Thanks for starting it!
If you guys can give a sign when there are no more suggestions for changes i will create the pull request at the Amsterdam/signalen-frontend repository.
All the resolved suggestions have been updated in the file locally.
If you guys can give a sign when there are no more suggestions for changes i will create the pull request at the Amsterdam/signalen-frontend repository.
That was my last suggestion!
@bartjkdp @Ainali @bvhme thanks a lot for the suggestions.
I've opened the pull request to the https://github.com/Amsterdam/signals-frontend repository.
Great 👍 thanks @ginokok1996! Let's continue in https://github.com/Amsterdam/signals-frontend/pull/1611
Added publiccode.yaml following the standard of: https://docs.italia.it/italia/developers-italia/publiccodeyml-en/en/master/index.html
We have filled in as much information as we could. But we suggest to check if they are correct.
Adding the publiccode.yaml file allows Dash Kube to correctly index this component at the commonground page found at: https://dashkube.com/commonground
It also allows for one button installation of the signalen application via Dash Kube.