Signalen / frontend

Frontend for Signalen, an application that helps cities manage and prioritize nuisance reports.
https://signalen.org
Mozilla Public License 2.0
10 stars 5 forks source link

Manifest file not correctly rendered #147

Closed bartjkdp closed 2 years ago

bartjkdp commented 3 years ago

Describe the bug

Currently we seem to have two manifest files:

The .json is referenced from the index.html but seems to contain only the template for the manifest without the variables substituted:

{
  "background_color": "$SIGNALS_BACKGROUND_COLOR",
  "display": "fullscreen",
  "icons": [
    {
      "src": "$SIGNALS_IOS_ICON",
      "sizes": "180x180",
      "type": "image/png"
    }
    ...
}

This results in an error in the browser:

image

To Reproduce Steps to reproduce the behavior:

  1. Go to the latest production version (v1.48.0)
  2. Launch the inspector
  3. See the errors about the incorrect manifest properties

Expected behavior

The index.html should refer to a version of the manifest with replaced variables (e.g. /manifest.json).

MauritsR commented 3 years ago

Fixed in https://github.com/Amsterdam/signals-frontend/pull/1686 (released in v1.54.0) - can you re-test this and close if successful?