Closed bartjkdp closed 2 years ago
Describe the bug
Currently we seem to have two manifest files:
The .json is referenced from the index.html but seems to contain only the template for the manifest without the variables substituted:
{ "background_color": "$SIGNALS_BACKGROUND_COLOR", "display": "fullscreen", "icons": [ { "src": "$SIGNALS_IOS_ICON", "sizes": "180x180", "type": "image/png" } ... }
This results in an error in the browser:
To Reproduce Steps to reproduce the behavior:
Expected behavior
The index.html should refer to a version of the manifest with replaced variables (e.g. /manifest.json).
Fixed in https://github.com/Amsterdam/signals-frontend/pull/1686 (released in v1.54.0) - can you re-test this and close if successful?
Describe the bug
Currently we seem to have two manifest files:
The.json is referenced from the index.html but seems to contain only the template for the manifest without the variables substituted:
This results in an error in the browser:
To Reproduce Steps to reproduce the behavior:
Expected behavior
The index.html should refer to a version of the manifest with replaced variables (e.g. /manifest.json).