search

Signalen / frontend

Frontend for Signalen, an application that helps cities manage and prioritize nuisance reports.
https://signalen.org
Mozilla Public License 2.0
10 stars 4 forks source link

De "Aanvullende informatie" gevraagd pagina toont melding nummers met "SIA-" ervoor #159

Open tcoenen opened 2 years ago

tcoenen commented 2 years ago

Describe the bug

The page for "Aanvullende informatie" shows the nuisance complaint number as "SIA-123", this is a hold over from the setup in Amsterdam. Now that the reaction request (reactie melder) feature is also used at other municipalities it should not show the "SIA-" part.

To Reproduce Follow the reaction request flow, until you hit the following screen and observe the nuisance complaint number contains the leading text "SIA-".

Screenshot 2021-12-02 at 12 15 01

The public nuisance complaint endpoint that is accessed during the rendering of this page (/signals/v1/public/signals/<uuid>) also returns the bare number as can be seen below:

Screenshot 2021-12-02 at 12 16 36

Expected behavior The "Aanvullende informatie" page should show the nuisance complaint number without prepended "SIA".

boris-arkenaar commented 2 years ago

Don't we want the _display value to reflect what we want to display? So with SIA for Amsterdam, without (or with another prefix) for other municipalities?

boris-arkenaar commented 2 years ago

Otherwise easy to update the frontend to use id instead of _display of course.

tcoenen commented 2 years ago

I think we should check with Amsterdam, but my hunch is that using id in stead of _display should be enough and permissible for Amsterdam.

boris-arkenaar commented 2 years ago

Amsterdam does want to keep the SIA prefix there. So, then I'm coming back to the backend changing the value of _display based on the tenant.