search

Signbank / FinSL-signbank

Web based database for sign language lexicons and corpuses. Fork of NGT-signbank (https://github.com/Signbank/Global-signbank).
https://signbank.csc.fi
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

Upgrade jQuery #248

Closed henrinie closed 6 years ago

henrinie commented 6 years ago

Github gives us the warning that jQuery2 is insecure, which probably is only partly true. We should upgrade to jquery 3 anyway at some point.

henrinie commented 6 years ago

This will take some work. Gloss_edit.js needs to be worked on and fixed, there are some deprecated shortcuts used. Unfortunately some other code snippets used don't seem to be compatible with jQuery3, one of them is typeahead. I am pondering whether it is worth to do this work and replace things like typeahead with another thing, or to completely revamp this.

henrinie commented 6 years ago

It seems that there exist a fork of typeahead that is probably maintained. https://github.com/corejavascript/typeahead.js

jeditable seems to be another one that should bit the dust.

henrinie commented 6 years ago

jeditable is another that is not fully compatible with jquery3.

henrinie commented 6 years ago

Seems like there is a new version for jeditable https://github.com/NicolasCARPi/jquery_jeditable