search

Signbank / Global-signbank

An online sign dictionary and sign database management system for research purposes. Developed originally by Steve Cassidy/ This repo is a fork for the Dutch version, previously called 'NGT-Signbank'.
http://signbank.cls.ru.nl
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

settings.FILE_UPLOAD_TEMP_DIR #1142

Open susanodd opened 5 months ago

susanodd commented 5 months ago

This setting is used in the code but is not defined anywhere.

It's referenced inside of some code for Flash videos, class VideoUploadToFLVField

The code in Admin ought to be broken since the setting is undefined. Is this code used in ASL? Is this obsolete? Anybody remember this code? PyCharm thinks @Woseseltops wrote the code.

susanodd commented 5 months ago

This code seems linked to Summernote.

In the admin, there are places where you may fill in contents for pages. This is (only) used for the pages in the About menu.

The interactive pages all use Python, Django templates, classes, database queries.

Woseseltops commented 5 months ago

This has been there since the initial commit. Feel free to remove

susanodd commented 5 months ago

Vintage Signbank!

susanodd commented 3 months ago

This causes problems with all the video upload routines. This is "internal Django stuff". For some reason it keeps using this setting and gets permission problems or file system problems. (This is the reason for the introduction of a new folder for importing videos in #1173. Django does not allow some operations on videos because that upload location is embedded in the upload_to of the FileField built into Django.)

As part of that import videos issue, I added more classes to the Video Admin, in order to inspect what "paths" are embedded in all the saved "video" data. This object/model table includes paths to video files on all previous servers! Perhaps some migration of these tables is needed. The files still exist but the "precursor" to the "writable" is also saved and does not necessarily match to anything anymore. The newer code only saves the "writable" path, not the entire path.

Since new issues involve adding even more kinds of videos, this needs to be repaired. Probably a migration on these tables to correct paths that include too much explicit folder prefaces.

@vanlummelhuizen would be the person who knows what is going on with these tables. He implemented the backup system.