Signbank / Global-signbank

An online sign dictionary and sign database management system for research purposes. Developed originally by Steve Cassidy/ This repo is a fork for the Dutch version, previously called 'NGT-Signbank'.
http://signbank.cls.ru.nl
BSD 3-Clause "New" or "Revised" License
19 stars 13 forks source link

The dictionary/info/ API endpoint does not check for the API token in Authorization:"Bearer ..." #1278

Open vanlummelhuizen opened 6 days ago

Woseseltops commented 6 days ago

Cool, I like how you're using a decorator here, can we do this everywhere?

Two things:

vanlummelhuizen commented 6 days ago

can we do this everywhere?

Yes, I already did in https://github.com/Signbank/Global-signbank/pull/1279/commits/cf9b1693daaa4e3499c41cc29a7e889930099548 which is now included in the PR.

  • let's make sure to also support the 'old' way of authenticating to this endpoint, so we're not suddenly forcing ELAN to make the switch.

To be sure I just tested the dictionary/info endpoint from my browser and it seems to work correctly.

  • Related recent pull request

@Woseseltops Just a reference or do you want me to look into that PR?

Woseseltops commented 5 days ago

Just a reference!