Signbank / Global-signbank

An online sign dictionary and sign database management system for research purposes. Developed originally by Steve Cassidy/ This repo is a fork for the Dutch version, previously called 'NGT-Signbank'.
http://signbank.cls.ru.nl
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

Confirm that no gloss has more than one AnnotationIdglossTranslation object per translation language of its dataset #1355

Closed susanodd closed 2 weeks ago

susanodd commented 3 weeks ago

A lot of the code uses filter plus first rather than get to retrieve these objects to avoid exceptions.

[DETAILS SKIP IF NO INTEREST] There's a mysterious bug with the video file naming for one of the glosses in tstMH. Some of the files are being named with the "lemma translation" instead of the "annotation translation". But there is no code that is doing this. I suspect that there may be more than one AnnotationIdglossTranslation for the language of that gloss. Originally code was using Gloss model field gloss.idgloss (which used to be a field of gloss, not a property as it is now #1352 ) (Can there be frozen code inside of really old objects?)

I rewrote some of the code to try to force it to work as intended. The "idgloss" property is used excessively to obtain the two-letter subfolder for videos. #1352 Really, if this code needs to be such a mess to prevent it from causing exceptions, something else is wrong.

During debugging of that I came up with other weird errors of the videos. It could also have to do with no videos on the development servers. That the code is working differently if there aren't actually any files. Or if the glosses have existed for 10 years and undergone many migrations. Maybe we need to purge really old test glosses, but also "links" to them in GlossVideo, etc. It did not used to be required to fill in all languages. Some really old NGT glosses do not have all the languages filled in. In spite of this being non-optional for new glosses.

susanodd commented 2 weeks ago

Okay, I checked tstMH and NGT. This is not a problem.