Add fields 'weak drop' and 'weak prop'

Signbank / Global-signbank

An online sign dictionary and sign database management system for research purposes. Developed originally by Steve Cassidy/ This repo is a fork for the Dutch version, previously called 'NGT-Signbank'.

http://signbank.cls.ru.nl

BSD 3-Clause "New" or "Revised" License

19 stars 12 forks source link

Add fields 'weak drop' and 'weak prop' #334

Closed ocrasborn closed 6 years ago

ocrasborn commented 7 years ago

These are phonology fields with three values (none, yes, no), and are a specification of the information in 'handedness'.
It would be nice if in the detail view we could display them in connection with the field handedness, ideally on the same line, so that we get a bit of a more compact view. The field labels could be abbreviated to "WD" and "WP" to make this possible. If this doesn't work out, put them immediately below handedness.
Also enable searching for this iformation.

ocrasborn commented 7 years ago

Oh, for the non-sign linguist: these refer to the possibility of articulating two-handed signs with one hand (weak drop) or vice versa (weak prop).

susanodd commented 7 years ago

Do you want to be able to explicitly set a value to None? This is the initial value when the field has never been set. Once you start setting and unsetting a checkbox, then in the database it gets set to 1 or 0. The repeat and altern fields are also like this.

ocrasborn commented 7 years ago

Let's make it so that they show the same behaviour as the repeat/altern fields.

susanodd commented 7 years ago

Okay, I just pushed it to the github. It's available in Gloss Detail View. I made it so it looks like what you describe first, that the WD, WP are on the same line after the Handedness. They only show up when set. You can set the checkbox when in edit mode. If they're not set they're invisible. (You can click to edit under the heading WD or WP.)

vanlummelhuizen commented 7 years ago

@ocrasborn This is live now.

ocrasborn commented 7 years ago

On Mac/Safari, I only see the field labels, but no checkboxes

screenshot 2017-09-04 12 52 49

susanodd commented 7 years ago

Click in the white space. :) (I'll adjust it.)

susanodd commented 7 years ago

Okay, I fixed the formatting. Now it shows the same ------ as the other fields. Querying has been added.

susanodd commented 7 years ago

@ocrasborn, @vanlummelhuizen put this on the live server.

ocrasborn commented 7 years ago

(See #371 for the nature of the values, I messed up my comments. These two fields WD/WP is where we need to distinguish between neutral/yes/no; for the number/letter etymology the checkbox in the interface is best).