search

Signbank / Global-signbank

An online sign dictionary and sign database management system for research purposes. Developed originally by Steve Cassidy/ This repo is a fork for the Dutch version, previously called 'NGT-Signbank'.
http://signbank.cls.ru.nl
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

Make it possible to set a default data language per dataset #480

Closed vanlummelhuizen closed 4 years ago

vanlummelhuizen commented 6 years ago

Instead of an application global default data language.

ocrasborn commented 6 years ago

Do you mean default in the sense of default-for-this-user? And where would this have effect? For the promotion of exchanging data and thus accessibility, we should take care to promote the use of English as the general default, for fields that are not mandatory.

vanlummelhuizen commented 6 years ago

It would for instance be used for the naming of video files. NGT video files now have Dutch names. Are you suggesting they should be changed to English?

ocrasborn commented 6 years ago

Ah I see. Nah, would prefer to keep them in Dutch.

vanlummelhuizen commented 6 years ago

Ok, I will go ahead with this then.

susanodd commented 6 years ago

This is needed for Homonyms List when the selected dataset is Shanghainese. (All the glosses are invisible, get_annotation_idgloss_translation sets this to an empty string.)

susanodd commented 6 years ago

I see what's happening. The default language is being set to Nederlands, but Shanghainese glosses only have English or Chinese translations.

ocrasborn commented 6 years ago

(Homonyms: see #495 )

susanodd commented 5 years ago

It's now possible for Dataset Managers to set the default language in the Dataset Detail View.

ocrasborn commented 5 years ago

Somehow in this process (or while revising the menu bar?) this page has been partly hidden under the menu bar again. The other two Dataset pages are fine. Could you look into this, @susanodd ?

susanodd commented 5 years ago

For which dataset does it do this? It's okay on my machine (for NGT).

susanodd commented 5 years ago

I'm up to date with github. Perhaps @Woseseltops modified the menu bar on the live server and didn't put it on github yet.

vanlummelhuizen commented 5 years ago

Solved. dataset_edit.js needed a variable language_choices which wasn't passed from the context into the template.

vanlummelhuizen commented 5 years ago

I believe this issue is done. Agreed, @ocrasborn, @susanodd ?

susanodd commented 5 years ago

Is there a default language for Lemma translations?

vanlummelhuizen commented 5 years ago

@susanodd Lemma (Idgloss) translations should use the Dataset languages and also the Dataset default language. Does that answer this old question?

vanlummelhuizen commented 4 years ago

I am closing this issue because the whole discussion seems to have ended.