search

Significant-Gravitas / AutoGPT-Code-Ability

🖥️ AutoGPT's Coding Ability - empowering everyone to build software using AI
MIT License
109 stars 34 forks source link

installing version 2.28.0 of git to make use of initial-branch flag. #203

Closed aarushik93 closed 4 months ago

aarushik93 commented 4 months ago

Installing version 2.28.0 of git to make use of initial-branch flag. This is needed so the locally created branch is the same as remote branch (main). Having the same branches means we don't need to do the master:main mapping when doing a first push to a new repo. While this works on cloudrun, depending on local git config settings, it was failing locally for engineers. It's also cleaner.

ntindle commented 4 months ago

Assuming you tested the dockerfile, the changes look good

Pwuts commented 4 months ago

Latest release is 2.44. Is the requirement specific to v2.28?

aarushik93 commented 4 months ago

@Pwuts 2.28+ have the flag enabled, I didn't go with the latest see here: https://discord.com/channels/1126875755960336515/1184577301204181164/1227676858867388416

but we can go more recent / latest if you want to, I'm not tied to 2.28 haha

Pwuts commented 4 months ago

There have been two breaking changes between v2.28 and v2.44, both very minor and unlikely to cause issues for many users. On the other hand, Git v2.28 is almost 4 years old and as such does not receive security patches. There are a number of CVE's registered for it.

I agree that we shouldn't necessarily be using the latest, cutting-edge version as it may have undiscovered issues. But we also shouldn't stick to a version that we know is too old to get patches. :)