search

SihenZhang / CrockPot

Bring Crock Pot from Don't Starve to Minecraft.
MIT License
19 stars 7 forks source link

Log spam about JEI plugins and crockpot. #50

Open Darkmega18 opened 2 years ago

Darkmega18 commented 2 years ago

These are the errors (below). I have several of them which recur throughout my latest log. I'm not sure what they're about.

it's minecraft 1.16.5, Forge 36.2.19, and CrockPot-1.16.5-1.6.2-release.jar along with a modpack's worth of other mods of course. My modpack specifically, "Order of All Creation: Relic hunters".


_java.lang.IllegalArgumentException: ItemStack value must not be empty. 4 air minecraft:air
    at mezz.jei.util.ErrorUtil.checkNotEmpty(ErrorUtil.java:206) ~[?:7.7.1.125]
    at mezz.jei.plugins.vanilla.ingredients.item.ItemStackHelper.getUniqueId(ItemStackHelper.java:88) ~[?:7.7.1.125]
    at mezz.jei.plugins.vanilla.ingredients.item.ItemStackHelper.getUniqueId(ItemStackHelper.java:28) ~[?:7.7.1.125]
    at mezz.jei.recipes.RecipeMap.addRecipe(RecipeMap.java:94) ~[?:7.7.1.125]
    at mezz.jei.recipes.RecipeMap.addRecipe(RecipeMap.java:75) ~[?:7.7.1.125]
    at mezz.jei.recipes.RecipeManagerInternal.addRecipe(RecipeManagerInternal.java:127) [?:7.7.1.125]
    at mezz.jei.recipes.RecipeManagerInternal.addRecipeTyped(RecipeManagerInternal.java:103) [?:7.7.1.125]
    at mezz.jei.recipes.RecipeManagerInternal.addRecipes(RecipeManagerInternal.java:96) [?:7.7.1.125]
    at mezz.jei.recipes.RecipeManagerInternal.<init>(RecipeManagerInternal.java:88) [?:7.7.1.125]
    at mezz.jei.load.PluginLoader.getRecipeManager(PluginLoader.java:144) [?:7.7.1.125]
    at mezz.jei.startup.JeiStarter.start(JeiStarter.java:74) [?:7.7.1.125]
    at mezz.jei.startup.ClientLifecycleHandler.startJEI(ClientLifecycleHandler.java:147) [?:7.7.1.125]
    at mezz.jei.startup.ClientLifecycleHandler.setupJEI(ClientLifecycleHandler.java:140) [?:7.7.1.125]
    at mezz.jei.startup.ClientLifecycleHandler.lambda$new$3(ClientLifecycleHandler.java:106) [?:7.7.1.125]
    at mezz.jei.startup.ClientLifecycleHandler$$Lambda$23384/1988417024.accept(Unknown Source) [?:7.7.1.125]
    at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus$$Lambda$3027/1287200676.invoke(Unknown Source) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus$$Lambda$3325/1335794721.invoke(Unknown Source) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) [eventbus-4.0.0.jar:?]
    at com.sihenzhang.crockpot.integration.jei.JeiUtils.reloadJei(JeiUtils.java:24) [?:1.6.2-release]
    at com.sihenzhang.crockpot.base.FoodValuesManager.deserialize(FoodValuesManager.java:219) [?:1.6.2-release]
    at com.sihenzhang.crockpot.network.PacketSyncFoodValues.lambda$handle$0(PacketSyncFoodValues.java:48) [?:1.6.2-release]
    at com.sihenzhang.crockpot.network.PacketSyncFoodValues$$Lambda$29493/2030823454.run(Unknown Source) [?:1.6.2-release]
    at net.minecraftforge.fml.network.NetworkEvent$Context.enqueueWork(NetworkEvent.java:215) [?:?]
    at com.sihenzhang.crockpot.network.PacketSyncFoodValues.handle(PacketSyncFoodValues.java:48) [?:1.6.2-release]
    at com.sihenzhang.crockpot.network.NetworkManager$$Lambda$19606/1419341182.accept(Unknown Source) [?:1.6.2-release]
    at net.minecraftforge.fml.network.simple.IndexedMessageCodec.lambda$tryDecode$3(IndexedMessageCodec.java:128) [?:?]
    at net.minecraftforge.fml.network.simple.IndexedMessageCodec$$Lambda$28252/819733433.accept(Unknown Source) [?:?]
    at java.util.Optional.ifPresent(Optional.java:159) [?:1.8.0_51]
    at net.minecraftforge.fml.network.simple.IndexedMessageCodec.tryDecode(IndexedMessageCodec.java:128) [?:?]
    at net.minecraftforge.fml.network.simple.IndexedMessageCodec.consume(IndexedMessageCodec.java:162) [?:?]
    at net.minecraftforge.fml.network.simple.SimpleChannel.networkEventListener(SimpleChannel.java:80) [?:?]
    at net.minecraftforge.fml.network.simple.SimpleChannel$$Lambda$3025/1713398243.accept(Unknown Source) [?:?]
    at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:247) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:239) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus$$Lambda$3027/1287200676.invoke(Unknown Source) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus$$Lambda$3325/1335794721.invoke(Unknown Source) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) [eventbus-4.0.0.jar:?]
    at net.minecraftforge.fml.network.NetworkInstance.dispatch(NetworkInstance.java:86) [?:?]
    at net.minecraftforge.fml.network.NetworkHooks.lambda$onCustomPayload$1(NetworkHooks.java:91) [?:?]
    at net.minecraftforge.fml.network.NetworkHooks$$Lambda$28240/447746712.apply(Unknown Source) [?:?]
    at java.util.Optional.map(Optional.java:215) [?:1.8.0_51]
    at net.minecraftforge.fml.network.NetworkHooks.onCustomPayload(NetworkHooks.java:91) [?:?]
    at net.minecraft.client.network.play.ClientPlayNetHandler.func_147240_a(ClientPlayNetHandler.java:1904) [?:?]
    at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:59) [?:?]
    at net.minecraft.network.play.server.SCustomPayloadPlayPacket.func_148833_a(SCustomPayloadPlayPacket.java:11) [?:?]
    at net.minecraft.network.PacketThreadUtil.func_225383_a(SourceFile:21) [?:?]
    at net.minecraft.network.PacketThreadUtil$$Lambda$28530/1141726116.run(Unknown Source) [?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(SourceFile:144) [?:?]
    at net.minecraft.util.concurrent.RecursiveEventLoop.func_213166_h(SourceFile:23) [?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(SourceFile:118) [?:?]
    at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213160_bf(SourceFile:103) [?:?]
    at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:948) [?:?]
    at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) [?:?]
    at net.minecraft.client.main.Main.main(Main.java:184) [?:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51]
    at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51]
    at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.5-36.2.19.jar:36.2]
    at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$480/940938116.call(Unknown Source) [forge-1.16.5-36.2.19.jar:36.2]
    at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?]
    at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?]
    at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?]
    at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?]_
SihenZhang commented 2 years ago

Actually, it's not a bug. Some of the JEI categories are paginated - you can see the items in the changing, based on this feature. JEI does not allow displaying empty ItemStack (ItemStack.EMPTY), but it will definitely create some spaces on the last page. If you want to display an empty ItemStack, the game will simply crash. However, you can display null and cause an error as above, it won't have any effect on the game. I'm also trying to find other solutions, but until I find another solution, it'll have to do for now.

Darkmega18 commented 2 years ago

you say theres JEI support, but for some reason I cannot access any sort of crafting guide in game other than info in the booklet about how to craft any of the crockpot foods. is there a specific addon or JEI version required? I can get a read out of food values for each of the food groups displayed and knowledge about the loot table for the golden garlic looking stuff you trade to piglins. but thats about it.

SihenZhang commented 2 years ago

JEI Support for Crock Pot Cooking Recipe will be in 1.16.5-2.0.0 and it will be released before this Friday. Here are some screenshots in development. ice_cream hot_cocoa

SihenZhang commented 2 years ago

By the way, is Netherosia really like garlic? It is designed concerning the shape of the meringue.

Darkmega18 commented 2 years ago

Oh very nice, on the jei stuff coming.

on the netherosia I think it's shape was just reminiscent of the shape the garlic takes in pams sprites. :V but zooming it in and looking at a picture of a meringue I can see what you hoped for. it's just very small I guess. image

but then when you take the garlic there and then look a picture like this of actual meringues image you can see where the confusion comes from just from visuals and the sprite's resolution.

khjxiaogu commented 2 years ago

JEI Support for Crock Pot Cooking Recipe will be in 1.16.5-2.0.0 and it will be released before this Friday. Here are some screenshots in development. ice_cream hot_cocoa

BTW, I think using "ANY" is not clear enough, 'cause it may not be consider as "must contains any", causing confuse.

khjxiaogu commented 2 years ago

Also, why not split recipe with a single top-level Or into multiple recipes in recipe json, this would greatly simplify JEI page.