search

SikandarJODD / svelte-animations

Svelte Components using Tailwind CSS & Framer Motion
https://animation-svelte.vercel.app
MIT License
279 stars 15 forks source link

Refactor Component Code Preview using `vite` provided `raw` import. #3

Closed theetherGit closed 2 months ago

theetherGit commented 2 months ago

I have added code import as top level instead of dynamic import. This works well, I think i can do that for all components. If you allow i wanna do some refactoring after going through this codebase.

Test Deployment - https://svelte-animations-ashy.vercel.app/

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-animations ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:11pm
SikandarJODD commented 2 months ago

I have added code import as top level instead of dynamic import. This works well, I think i can do that for all components. If you allow i wanna do some refactoring after going through this codebase.

Test Deployment - https://svelte-animations-ashy.vercel.app/

Yeep u can go for refactoring the components in new branch ?

theetherGit commented 2 months ago

Do you have anything in mind you want to refactor? We should go for accessibility for every element so we can use bits-ui as i suggested in the tweet also. Are you in favour of bits-ui?

Second thing if you wanna make it more easy to use you can introduce a cli - suggestion for the future currently we should focus on implementing all possible components you have in mind.

SikandarJODD commented 2 months ago

Yeep Agreed I don't know how to work with bits ui..but i will learn...for now i am working on 3 Input Components from Luxe