search

Silari / DBContext

A discord.py based bot with module loading functions - aka contexts
MIT License
1 stars 0 forks source link

Add StreamRecord.adddetail #23

Closed Silari closed 3 months ago

Silari commented 4 years ago

add adddetail command to StreamRecord which takes a detailed record dict and updates the fields it needs to to supplement a normal record.

Silari commented 4 years ago

This isn't really feasible - only Twitch really has different stuff available for online vs offline versions. For picarto/piczel the only real difference is the additional multistream info (and stream start time for picarto, which isn't really needed).

Twitch could use the user info for the avatar URL for online streams, which would only need to be added once when the stream first comes online. Would need work to get it in there though since the other two wouldn't need it. Maybe modifying twitchclass.updateparsed to do it?

Silari commented 4 years ago

This was superceded by #33 which includes a mechanism in updateparsed to add the User record info to any new Stream records that are generated. As such Twitch records are 'complete' and there's no need to add detail, and anything we do add later (Followers is the only thing we kind of want that is missing at this time) will use this new mechanism, not an adddetail command.