search

Silarn / EDMC-BioScan

Exobiology plugin for EDMC - Species deduction engine for biological signals and analysis aid. Quickly determine targets for research. Discord: https://discord.gg/RhY7KPzTht
GNU General Public License v2.0
13 stars 1 forks source link

focus body signals #11

Closed Saffiejosia closed 1 month ago

Saffiejosia commented 1 month ago

L's, when setting the "focus body signals" to never, so it displays all bodies in the system, it stops giving me details about ongoing sampling. When choosing one of the filter setting it does give me my sampling progress inclusive distance and so on. I like the never filter setting so i don't have to scan every planet in de system map for bio's i missed or never bothered to sample, when revisiting a system. This is a function which i dearly miss in observatory with bioinsights plugin. Maybe it is by design but i would like to see all bio's when entering a system and also see my progress when sampling on a planet ;)

Regards cmdr Safkirk

p.s. after some what more fooling around i think i understand the philosophy behind this setting. When filtered it still shows all bodies when not near one of the planets. When close it focusses on one body and therefore also on sampling.

Silarn commented 1 month ago

Just to make sure I understand the issue, it's not displaying the active scan information if the focus setting is on 'never'?

Meaning compass heading, sample distance, etc?

In that case that's definitely a bug.

Silarn commented 1 month ago

Just to be clear the focus setting should only change the way the detail list is displayed. In other words, the list showing the predictions / found species for all of the planets in the system.

The active scan display should not be affected.

I have another change staged for release so once I can resolve this I'll probably publish those changes.

Silarn commented 1 month ago

I do see the issue, and I believe I have a fix. Basically, I wanted the active scan display to match the setting for 'focus' so that the list would be filtered at the same time that the active scan display was enabled. However, this did skip the active scan display code when the filter was set to 'None' because the checks were identical.

I decided to consolidate these two checks into a new function to simplify the code a bit and make the check a bit more readable.

So, there's now a flag to indicate if the result is meant to be for the list filter or the active scan display. The active scan display should now enable if the focus mode is 'none' at the same time as the 'on approach' setting. (Meaning, when the game considers you to be 'at' that planet in the HUD.)

In other words, this new function should return 'True' for the active scan display when it returns 'False' for the detail list filter if this is set to 'None' and you are considered 'at' a planet.

I'll test this as soon as I can.

Silarn commented 1 month ago

After thinking about this for a bit I actually think it makes more sense to allow the active scan display to appear when 'at' a planet when the focus setting is 'On Surface' as well. Not being able to see the display while flying seems quite limiting. So I'll adjust the logic a bit to also exclude the 'On Surface' setting.