SilenKZYoung / CuboidAbstractionViaSeg

This repo is a PyTorch implementation for Paper "Unsupervised Learning for Cuboid Shape Abstraction via Joint Segmentation from Point Clouds"
MIT License
65 stars 8 forks source link

Weights for `W_CST` - translation $t_m$ not included in loss #10

Open GregorKobsik opened 10 months ago

GregorKobsik commented 10 months ago

Hi @SilenKZYoung

I'm working on the code and trying to reconstruct your results. The pretrained checkpoints work fine and create the described results in your paper.

But I discovered, that the W_CST-Loss ist set to 0 per default in training.

parser.add_argument ('--W_CST', default = 0.00, type = float, help = 'CST loss weight, this loss is only for generation application')

Does it hurt the performance of the model? I could also not find any note of it in the published paper.

Thus the cuboid vector $p_m$ is only trained for rotation $r_m$, scale $s_m$ and existence $\delta_m$, and the translation $t_m$ does not appear in the loss. This leads to the position of the cuboids to be randomly distributed in the 3D space, which is not the case with the pretrained checkpoints.

This design decision seems somewhat counterintuitive. Could you provide some ratio on this choice?

FishWoWater commented 3 months ago

@GregorKobsik Hi, Kobsik~ Have you figured out this? Seems that when setting W_CST to 0, the network doesn't learn a translation vector, and use the centroid of segmentation assignment instead. Do you have any idea on which one is better?