Silence-GitHub / BBMetalImage

A high performance Swift library for GPU-accelerated image/video processing based on Metal.
MIT License
988 stars 126 forks source link

Black pixels on the Image when using .hueFilter #22

Closed sebastianroth1 closed 4 years ago

sebastianroth1 commented 5 years ago

When I use the static image hueFilter, black pixels will appear on the filtered image. This happens on iPhone 5s - iPhone 10, but not on iPhone 11. I tested the hue filter in the demo project with this photo and did not make any changes in the code. On the filtered image you can see the black pixels: image The black pixels also occur sometimes with other filters.

Silence-GitHub commented 5 years ago

@heythiswildidea Thank you for issuing me. For hue filter, replacing half4 with float4 in the shader solves the problem. Could you please tell me which filters have the same problem? I will fix them in the new version.

sebastianroth1 commented 5 years ago

Good job! Thank you for solving this problem! I just did some more tests. Apparently only this filter is affected.

Silence-GitHub commented 5 years ago

Version 1.0.10 fixes it.