search

SilenceLove / HXPHPicker

Photo/Video Selector-Supports LivePhoto, GIF selection, online download of resources on iCloud, and editing of photos/videos
MIT License
364 stars 74 forks source link

image is set on a background thread - PhotoEditorContentView #91

Closed t3b123 closed 2 years ago

t3b123 commented 2 years ago

in the PhotoEditorContentView.swift file you set the image on the background thread. You should change it to main thread when the user crops the image.

var image: Any? { DispatchQueue.main.sync { imageView.image } }

t3b123 commented 2 years ago

setting an image should be back on the main thread no?

SilenceLove commented 2 years ago

There is no setting here, only get

t3b123 commented 2 years ago

sorry I got it confused. I meant getting on the main thread

t3b123 commented 2 years ago

if you make an edit to a photo you will see that xcode with give you a warning to get it from the main thread instead. check and please let me know