SilenceLove / HXPHPicker

Photo/Video Selector-Supports LivePhoto, GIF selection, online download of resources on iCloud, and editing of photos/videos
MIT License
364 stars 74 forks source link

localized in PhotoEditorViewController #92

Closed t3b123 closed 2 years ago

t3b123 commented 2 years ago

You forgot to localize this string "正在处理..."

` import UIKit

extension PhotoEditorViewController { func exportResources() { if imageView.canReset() || imageView.imageResizerView.hasCropping || imageView.canUndoDraw || imageView.canUndoMosaic || imageView.hasFilter || imageView.hasSticker { imageView.deselectedSticker() ProgressHUD.showLoading(addedTo: view, text: "正在处理...".localized, animated: true) imageView.cropping { [weak self] in guard let self = self else { return } if let result = $0 { ProgressHUD.hide(forView: self.view, animated: false) self.isFinishedBack = true self.transitionalImage = result.editedImage self.delegate?.photoEditorViewController(self, didFinish: result) self.finishHandler?(self, result) self.didBackClick() }else { ProgressHUD.hide(forView: self.view, animated: true) ProgressHUD.showWarning( addedTo: self.view, text: "处理失败".localized, animated: true, delayHide: 1.5 ) } } }else { transitionalImage = image delegate?.photoEditorViewController(didFinishWithUnedited: self) finishHandler?(self, nil) didBackClick() } } }

`

SilenceLove commented 2 years ago
image

This localization is processed

t3b123 commented 2 years ago

Yes, however, I added the .localized into this function. It was missing from your code

SilenceLove commented 2 years ago

I don't quite understand what you mean, what is your problem?

t3b123 commented 2 years ago

your code only had this ProgressHUD.showLoading(addedTo: view, text: "正在处理...", animated: true)

instead of this ProgressHUD.showLoading(addedTo: view, text: "正在处理...".localized, animated: true)

SilenceLove commented 2 years ago

🤦I just discovered it, I'll fix it soon

SilenceLove commented 2 years ago

I will release v1.4.5 later