NullPointerException from recalculating stats

[jeremiahwinsley]

Versions

• Silent Gear: 2.6.32
• Silent Lib: 4.10.0
• Forge: 36.2.8
• Modpack: N/A
• Optifine Installed: No

Expected Behavior

The server connection should not fail.

Actual Behavior

When joining a server under certain circumstances, possibly to do with specific tools, the connection will fail with a NullPointerException. This happens without Curious Elytra, but I was only able to consistently reproduce it with Curious Elytra installed.

The issue appears to be with the RecalculateStatsPacket. In this case, the packet attempts to send another recalculate packet for the max durability, and fails because net.minecraft.client.Minecraft.getConnection() returns null.

Links/Images

• https://gist.github.com/jeremiahwinsley/2a081ebb7579a91ea3be92234de09698

Steps to Reproduce the Problem

1. Create server and client instance with Forge 36.2.8, install Silent Gear, Curious Elytra, and their dependencies.
2. Add -Dforge.logging.mojang.level=debug to client java args, so that the full stack trace shows up in the logs.
3. Create a Silent Gear elytra (tested with phantom membrane and fine silk), and wear it in the Curio back slot.
4. Log out of the server, then attempt to log back in.

[jeremiahwinsley]

Issue still exists on 1.18.1. Silent Gear: 2.8.2 Silent Lib: 6.0.0 Forge 39.0.9

Curious Elytra: 5.0.0.1 Curios: 5.0.4.2 Caelus: 3.0.0.1

[MoonMoonShark]

still having this problem in 1.18.2

Forge: 40.1.84 Silent Gear: silent-gear-1.18.2-2.10.16.jar Silent Lib: silent-lib-1.18.2-6.2.0.jar