SilentChaos512 / Silent-Gear

Modular tool/armor mod (formerly part of Silent's Gems)
https://www.curseforge.com/minecraft/mc-mods/silent-gear
MIT License
81 stars 37 forks source link

[1.20.x] Items do not stack in the salvage #612

Open ffuentesm opened 1 year ago

ffuentesm commented 1 year ago

Versions

Expected Behavior

Items should move to the inventory on the free slots.

Actual Behavior

If the salvage inventory is not free, the input item will not be converted.

Links/Images

image

Steps to Reproduce the Problem

  1. add an item to the salvage
  2. do not free the inventory
  3. add a second item to the salvage
bandti45 commented 1 year ago

I think this is intentional, with the large amount of different items you can get in a break down of a full tool you might only be able to fit one full break down at a time so its better to make sure the inventory is clear. A hopper can pull the contents out automatically though.

SilentChaos512 commented 1 year ago

Kind of intentional, mostly just laziness to be honest, haha... I might update the code to stack items someday.