SilentChaos512 / Silent-Gear

Modular tool/armor mod (formerly part of Silent's Gems)
https://www.curseforge.com/minecraft/mc-mods/silent-gear
MIT License
81 stars 37 forks source link

[1.19.2] Errors with KubeJS. (java.util.ConcurrentModificationException). #617

Open Gbergz opened 1 year ago

Gbergz commented 1 year ago

Versions

Expected Behavior

No errors with KubeJS when loading into worlds.

Actual Behavior

KubeJS errors (java.util.ConcurrentModificationException) when joining world.

Links/Images

Full KubeJS logs: https://gist.githubusercontent.com/Gbergz/a405839cb54209016f81b6abb2444746/raw/dee803a0013a2e350221deaa5f22143ca17c31fb/gistfile1.txt Specific error in log: https://gist.githubusercontent.com/Gbergz/28cc86fb6402c1dded3c9da3a1d5fe5d/raw/4ae9820cfd183092871fd927e033ad23e17e806e/gistfile1.txt screenshot

Steps to Reproduce the Problem

Latest KubeJS, Latest Silent Gear, Gems+ Libs etc. Join a world. KubeJS errors. (java.util.ConcurrentModificationException)

Gbergz commented 1 year ago

This is still an issue.

Versions now:

Forge: 43.2.21 KubeJS: 1902.6.1-build.352 Silent Gear: 3.2.6 Silent Gems: 4.4.2 Silent Lib: 7.0.3

Logs

(It's the same error as above but I'll link them here again.) Full KubeJS logs: https://gist.githubusercontent.com/Gbergz/cd1f5f5275d3c65607e2bb223f8346c2/raw/ac26a5e10d1313d417069784caaa72640e8c76c3/gistfile1.txt Specific error in log: https://gist.githubusercontent.com/Gbergz/5d35019454880d00e59f43ed25ef0eb2/raw/6aaa16380f20474786ae519d76226e583ddf124f/gistfile1.txt

Edit: Tried latest kubejs too as of writing this (build.364), though no changes. Same errors.

rckymtnrfc commented 1 year ago

I've been trying to find the cause of this error. Finally tracked it down. You can roll back to KubeJS 1902.6.0-build.142 to temporarily get around the bug. It seems to be a conflict between any 6.1 version of KubeJS and Silent Gear. Hopefully this gets fixed soon as it completely breaks loading any of the KubeJS server scripts.

rckymtnrfc commented 1 year ago

Forget rolling back KubeJS. I found the fix on the KubeJS Discord after some searching.

Gnome on Discord said "Silent Gear doesn't allow the recipes even[t] to run asynchronously, which will result in an ConcurrentModificationException. To fix this, set allowAsyncStreams to false in kubejs/config/common.properties."

I tried it, and it worked for me!