search

SilentChaos512 / Silent-Gear

Modular tool/armor mod (formerly part of Silent's Gems)
https://www.curseforge.com/minecraft/mc-mods/silent-gear
MIT License
84 stars 37 forks source link

Salvager Processing Issues #732

Open RacerDelux opened 3 weeks ago

RacerDelux commented 3 weeks ago

Versions

silent-gear-1.21.1-neoforge-4.0.6 release on October 20, 2024

Expected Behavior

When I put an item in (lets take an iron sword for example), when it finishes, I expect it to output the materials in the output section. If I put another iron sword in, I expect it do the same. I shouldn't need to clear the output to process another item.

Note, while this bug is dealing with two items of the exact same type, similar behavior is seen for ANY second item. I would think that I should be able to continuously process items of any type until the output is full?

Actual Behavior

The first iron sword processes just fine. The second iron sword gets processing progress, then stops when it reaches the end. If I remove the materials given by the first iron sword, the progress resets. After it finishes processing, the salvaged materials appear in the output.

Steps to Reproduce the Problem

1, Put an iron sword into the salvager. Once it is done, without removing anything from the output, put another iron sword in.

  1. The 2nd iron sword will never finish processing until the output is cleared. When you clear the output, the progress of the 2nd iron sword is then reset. This is 100% repeatable.
SilentChaos512 commented 2 weeks ago

Someone on Discord also mentioned the salvager not working with item pipes from the Pipez mod. While not technically the same issue, I'm logging it here since it's kind of related. The salvager's inventory code just needs a general overhaul.

RacerDelux commented 2 weeks ago

Someone on Discord also mentioned the salvager not working with item pipes from the Pipez mod. While not technically the same issue, I'm logging it here since it's kind of related. The salvager's inventory code just needs a general overhaul.

While doing the overhaul, would it be possible to make it so if an item is inserted that can't be broken down, it will be ejected out one of the sides? Like the bottom. So item insertion - front or top Item removal (deconstructed materials) - back, left or right Item rejection - bottom

SilentChaos512 commented 2 weeks ago

I think it would be better for the input slot to not even accept items that can't be processed.

RacerDelux commented 2 weeks ago

I would be a-ok with that. I can still give it a high priority in pipes, and it would just skip anything not compatible.

KrypticNexus commented 4 days ago

I just started looking at why i was having this same issue. nothing but hoppers works on the salvager. i also have the item stop and restart issue. my way around it currently is hoppers connected to my ae network going in to salvager then i have a hopper on the bottom removing items and then its connected to ae network also. some of the updates that was suggested above would be a welcome addition.

I would love to have some kinda pipe that works over hoppers.

ExiledMiner04 commented 3 days ago

I noticed it used to work with sophisticated storage's hopper modules in chests and barrels above and below it, but now nothing. so something is definitely busted between 1.21.1 and 1.20.x.

ExiledMiner04 commented 2 days ago

Ok its sophisticated storage's problem. Had same issue with mud in a sugarcane farm. Vanilla hoppers work fine on mud into Sophisticated Storage's barrels and chests. Its hopper module/advanced hopper module does not work.

ExiledMiner04 commented 1 day ago

He told me that he never intended for hopper modules to grab item entities. Yet this is not item entities with the salvage block, so I guess we're back to square one.