supercharged books from apotheosis

SilentChaos512 / SilentGems

A Minecraft mod mostly about tools and colorful building blocks.

MIT License

47 stars 21 forks source link

supercharged books from apotheosis #543

Closed yggdrasil75 closed 2 years ago

yggdrasil75 commented 3 years ago

Versions

Silent Gear: 2.6.26 N/A
Silent Lib: 4.9.6
Forge: 36.1.31
Modpack: N/A
Optifine Installed: No

Expected Behavior

prevent apotheosis from creating higher level silent gear supercharge books

(Description here)

Actual Behavior

level 7 supercharged enchanted book appears on champions champion mobs

(Description here)

yggdrasil75 commented 3 years ago

sorry, not blight. champion https://www.curseforge.com/minecraft/mc-mods/champions/screenshots

SilentChaos512 commented 3 years ago

This issue here is (hopefully) that the Supercharged enchantment doesn't override the canVillagerTrade and canGenerateInLoot methods (strangely, those seem to be absent in dev, maybe they were added after 1.16.3, which Gems is still built against.) I haven't heard of Star Charged having this kind of problem at least, and it does override those.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.