SilentCicero / ipfs-mini

A super tiny module for querying IPFS that works in the browser and node.
MIT License
152 stars 40 forks source link

fix browser-xhr bundling for es5 lib #2

Closed pelle closed 7 years ago

pelle commented 7 years ago

When adding ipfs-mini to a web pack like build process for a browser it can't find the xml http request object.

It's a pretty simple fix that just needs a mapping from the lib version to the browser lib version.

ipfs-mini

Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the MIT License.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2c2522ff2e196d7341c55ad0d054d629204ffd02 on pelle:fix-es5-xhr into 9f3c2e16a9430fcdcc19e107f2b0c284ef1e0dac on SilentCicero:master.