SilentCicero / ipfs-mini

A super tiny module for querying IPFS that works in the browser and node.
MIT License
152 stars 39 forks source link

new cors error #9

Closed kangarang closed 6 years ago

kangarang commented 6 years ago

Description

Haven't changed any code recently, but I'm now seeing a cors error:

ss- 2018-06-13 at 4 20 03 pm

Versions

SilentCicero commented 6 years ago

Hmm, I would check your UI serving environment and Infura. Nothing has changed code wise for IPFS-Mini, it is simply making XHR requests to an IPFS APi.

On Wed, Jun 13, 2018 at 4:27 PM, kangarang notifications@github.com wrote:

Description

Haven't changed any code recently, but I'm now seeing a cors error:

[image: ss- 2018-06-13 at 4 20 03 pm] https://user-images.githubusercontent.com/18040654/41376192-785a5c74-6f26-11e8-999b-2e312b58a081.png Versions

  • Node/NPM: 9.10.0 / 6.1.0
  • Browser: Chrome 67.0.3396.87

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SilentCicero/ipfs-mini/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AJWhXv5VE5L6cW_4uYVytyrWgApuRlP5ks5t8XWygaJpZM4Um4W6 .

kangarang commented 6 years ago

ahh, it's happening if i send several (> 6) separate requests while mapping through an array of multihashes

kangarang commented 6 years ago

thanks nick

0xferit commented 6 years ago

@kangarang I have the same problem in subsequent calls to getJSON. After the first call, subsequent calls get sent without any headers.

How did you fix your problem?

kangarang commented 6 years ago

@ferittuncer i wrote a function that batches ipfs get calls.

it's not the most readable function, but here it is

SilentCicero commented 6 years ago

Okay will review, thanks guys! If you find a fix just make a pr, this lib is super simple

Sent from my iPhone

On Aug 22, 2018, at 10:43 AM, Isaac Kang notifications@github.com wrote:

@ferittuncer i wrote a function that batches ipfs get calls.

it's not the most readable function, but here it is

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.