search

SilentSys / orhelper

orhelper is a module which aims to facilitate interacting and scripting with OpenRocket from Python
GNU General Public License v2.0
16 stars 17 forks source link

pull rocket from simulation, not simulation options #9

Closed JoePfeiffer closed 3 months ago

JoePfeiffer commented 1 year ago

OR version 22.02 has moved the getRocket() method from simulation options to the simulation itself. This updates the Monte Carlo example to this version.

SilentSys commented 1 year ago

Thanks for this! I didn't realize a new version of OR was released. I'm currently busy but I'll have some time to look into it in a few weeks.

christophfroehlich commented 12 months ago

Are there any updates on this? Apart from this change, is orhelper compatible to OR 22? It seems that they updated to Java 11.

I guess this has to be updated, too. https://github.com/SilentSys/orhelper/blob/d9c58584ad142a43b96f55d6d6231b99ce3268f5/orhelper/_orhelper.py#L14

JoePfeiffer commented 12 months ago

Are there any updates on this? Apart from this change, is orhelper compatible to OR 22? It seems that they updated to Java 11.

I guess this has to be updated, too.

https://github.com/SilentSys/orhelper/blob/d9c58584ad142a43b96f55d6d6231b99ce3268f5/orhelper/_orhelper.py#L14

Yes, with the change in the PR I've been using it successfully with 22.02. I'd forgotten the necessary change to the default classpath, since I very rarely run it from the directory containing the jar file so I need to set the environment variable correctly anyway.

SiboVG commented 6 months ago

@SilentSys care to merge this change?