1.12.2 Night Vision ring strobing sky

[raltus]

General Info

• [x ] I am running a modpack
• [x ] I can reproduce this issue consistently
  • [x ] In single player
  • [ ] In multiplayer
• [ x] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I'm having the same problem.
• [ ] I am crashing and can provide my crash report(s)
• [x ] I am using the latest version of the mod

Client Info

• Minecraft Version: 1.12.2

• Forge Version: 14.23.5.2772

• Mod Version: 1.12.2-1.6.8

• Java Version: 1.8.0.201 (64 bit)

Issue Description

I am not sure if this is a conflict with something else I'm using or not. Normal night vision works fine. I was checking out the ore generation for the mods I'm putting together and went to grab a night vision potion in creative when I noticed the ring. I thought it would be better than drinking multiple potions while I looked around. The moment I put it on the night sky started flashing rapidly. It is fine if I'm in a cave, but on the surface at night or using spectator underground it's like the potion effect is constantly ending with a much faster visual effect even though it's still going. The inventory effects list also flashes whether it's day or night.

Reproduce Steps

Additional Information

[Silentine]

I'll need to look into this myself.

If I were to guess; it could be due to the duration be set at the exact moment the effect is supposed to start fading in/out.

[raltus]

I made a short video of what I am seeing and sent a pm with the unlisted link and the mod list on CurseForge.

[raltus]

I have found the conflicting mod. There is something in The Erebus that is causing the issue. I'll make a issue on their page for this.

Apparently this isn't a first. There is a closed issue from 2016 that has the same problem. Not sure how to do a reference link so I'll just paste it here. https://github.com/vadis365/TheErebus/issues/558

[raltus]

Fixed in latest version of The Erebus.