Silex / docker.el

Manage docker from Emacs.
752 stars 77 forks source link

Performance issues after docker-status introduction #177

Closed noorul closed 2 years ago

noorul commented 2 years ago

With the changes in https://github.com/Silex/docker.el/pull/84, I see that there is significant lag testing my patience. Please provide a mechanism to disable this.

Silex commented 2 years ago

@joshbax189 any idea how to implement this?

joshbax189 commented 2 years ago

@Silex yeah should be greatly improved by #171

noorul commented 2 years ago

If anyone else is facing this issue, as a temporary mechanism I added the following to my config

(defun docker-container-description-with-stats() "Containers")
(defun docker-image-description-with-stats() "Images")
(defun docker-network-description-with-stats() "Networks")
(defun docker-volume-description-with-stats() "Volumes")
Silex commented 2 years ago

@noorul I'm working on the async branch which should dramatically improve performances. I'm also thinking about a global flag to disable stats.

Silex commented 2 years ago

@noorul, @joshbax189 can you guys give the async branch a test?

I need to handle things like error handling but it'd be functional.

Then I'll work on the magit-section ($ buffer) and the vterm support.

Silex commented 2 years ago

@noorul: check the latest version and tell me if that's ok or reopen if you still need a mechanism to disable the status.

noorul commented 2 years ago

This looks good to me with respect to performance. One issue is that the too many messages are being dumped to message buffer (bottom of the screen). This distracts a lot.

noorul commented 2 years ago

Maybe a dedicated buffer like magit-process buffer could be better.

Silex commented 2 years ago

This is the plan, yes.