SiliconLabs / matter

Matter is creating more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.
https://www.silabs.com/wireless/matter
Apache License 2.0
151 stars 45 forks source link

fix_uart_log_and_icd_and_bootloader_link #156

Closed ihidchaos closed 5 days ago

ihidchaos commented 3 weeks ago
  1. fixed the undefined compile error of uartConsoleInit caused by not including uart.cpp when --uart_log parameter is enabled.
  2. fixed the undefined compilation error of emberAfIcdManagementClusterRegisterClientCallback and emberAfIcdManagementClusterUnregisterClientCallback when ICD is enabled.
  3. Fix the problem that the bootloaderFiles array was defined incorrectly and the corresponding bootloader could not be found.
  4. When passing --bootloader parameter, generate merge file with suffix in hex format, so as to avoid the failure of merging the same file by repeating the allow command.

test command:

./scripts/examples/gn_silabs_example.sh ./examples/smoke-co-alarm-app/silabs ./out BRD4187C --icd --low-power --bootloader --uart_log

I sincerely hope you can merge this fix into the upstream community repository as well.

lboue commented 3 weeks ago

@ihidchaos Why don't you create your PR in the upstream repository here: https://github.com/project-chip/connectedhomeip?

ihidchaos commented 3 weeks ago

@ihidchaos Why don't you create your PR in the upstream repository here: https://github.com/project-chip/connectedhomeip?

As you can see, the code changes are mainly for the silabs platform. My idea is that if the code is accepted by silabs, then merging into the community repository will be the next step (whether by me or by the core staff).

lboue commented 3 weeks ago

As you can see, the code changes are mainly for the silabs platform. My idea is that if the code is accepted by silabs, then merging into the community repository will be the next step (whether by me or by the core staff).

@ihidchaos It's up to you. I've already done upstream PR that was accepted.