SiliconValleyInsight / siliconvalleyinsight.github.io

Silicon Valley Insight Website
http://siliconvalleyinsight.github.io
0 stars 1 forks source link

New version of siliconvalleyinsight.github.io (Beta) #17

Closed alexnodejs closed 9 years ago

alexnodejs commented 9 years ago

@JohnYangSam Please check.

List of unimplemented features:

Since this is an urgent task, I will try to create additional PR(s) on this weekend which should include "advanced scrolling features".

P.S. please see this who don't want to test. http://screencast.com/t/iPYdNGCak

JohnYangSam commented 9 years ago

@alexnodejs added copy. A few pieces of feedback:

JohnYangSam commented 9 years ago

You've got the goahead to merge this into the main branch to display on the website branch once the tweaksa re updated!

alexnodejs commented 9 years ago

@JohnYangSam

alexnodejs commented 9 years ago

@JohnYangSam I'm going to merge this PR with master, it seems all is aligned now.

Please see. http://screencast.com/t/kr8i9z5MZi8

Also please give me some review / feedback.

JohnYangSam commented 9 years ago

@alexnodejs good updates.

@benigeri mentioned that since we are hijacking the scrolling, it might be causing the weird scrolling on the right (and the extra bounce on both the left and the right when we get to the bottom). For now, on the main branch, could we see what it looks like without the scrolling?

Also, I think I see what you were trying to do with the scrolling at the end to align with the countries. I don't think we need that for now - the smooth scrolling might be better for the moment.

Let's sync with denis on designs.

alexnodejs commented 9 years ago

@JohnYangSam, @benigeri

I will provide version without "scroll to fixed" functionality in a PR from next branch soon https://github.com/SiliconValleyInsight/siliconvalleyinsight.github.io/tree/alexv/fixes-for-new-site-version