search

SilkMC / silk

Silk is a Minecraft API for Kotlin - targetting Fabric, Quilt and Paper
https://silkmc.net/silk/docs/
GNU General Public License v3.0
100 stars 12 forks source link

Update CoroutineTask.kt #15

Closed r0yzer closed 2 years ago

r0yzer commented 2 years ago

I think it would be more fitting if the task does run forever if you do not specify it otherwise, it cost me about 5 minutes already three times

Skyslycer commented 2 years ago

But it could cost people hours to find the issue later, because they forgot a loop time number.

jakobkmar commented 2 years ago

Yes I won't change the default value of howOften for this function, but it might be a good idea to introduce a new function just for repeating tasks.

Skyslycer commented 2 years ago

Yes I won't change the default value of howOften for this function, but it might be a good idea to introduce a new function just for repeating tasks.

Would do that too.

r0yzer commented 2 years ago

hat mich schonwieder 5 minuten gekostet (cost me 5 mins again)

flerbuster commented 2 years ago

mich auch

jakobkmar commented 2 years ago

In 1.8.0 there is the infiniteMcCoroutineTask function, so this PR can be closed.