search

SilkMC / silk

Silk is a Minecraft API for Kotlin - targetting Fabric, Quilt and Paper
https://silkmc.net/silk/docs/
GNU General Public License v3.0
100 stars 12 forks source link

Add player join and player quit events #30

Closed mooziii closed 11 months ago

btwonion commented 1 year ago

maybe you should create playerEvents instead of PlayerConnectionEvents

btwonion commented 1 year ago

and we have to distinguish between ServerPlayer and Player

mooziii commented 1 year ago

i think PlayerConnectionEvents may be better as you can separate packet, join, quit stuff and stuff like player chat event

btwonion commented 1 year ago

okay. then i will create the player for client only events

btwonion commented 1 year ago

events that are available for both sides

btwonion commented 1 year ago

i think it's fixed with d467bac

jakobkmar commented 1 year ago

no, the ones in the core module at the moment are not feature complete

jakobkmar commented 1 year ago

I will implement the rest of the required features in core myself, but keep this PR open until of that is resolved.