search

SilkMC / silk

Silk is a Minecraft API for Kotlin - targetting Fabric, Quilt and Paper
https://silkmc.net/silk/docs/
GNU General Public License v3.0
100 stars 12 forks source link

feat(nbt): add serializers for tags and item stack #40

Open SettingDust opened 1 year ago

SettingDust commented 1 year ago

Is there a code style guideline?

SettingDust commented 1 year ago

Ready for reviewing

jakobkmar commented 1 year ago

Thanks, will check it out in a few days, ping me if I forget it.

SettingDust commented 1 year ago

Thanks, will check it out in a few days, ping me if I forget it.

Ping

jakobkmar commented 1 year ago

Looking good so far - cloned it locally, I'll add a few commits to this PR and then request a review from f0x.

SettingDust commented 1 year ago

There is something wrong. The BaseTagSerializer require a TagEncoder to fetch the tag. So it can't be used in other formats. So the serializers should be internal or implement a standalone parser for serializer.