search

SilkMC / silk

Silk is a Minecraft API for Kotlin - targetting Fabric, Quilt and Paper
https://silkmc.net/silk/docs/
GNU General Public License v3.0
100 stars 12 forks source link

[Proposal] Add a packet format in network module #42

Open SettingDust opened 1 year ago

SettingDust commented 1 year ago

Add a packet serial format to network module and use it instead of cbor. And maybe the network should register channel standalone instead of "subchannel" of silk

jakobkmar commented 1 year ago

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

SettingDust commented 1 year ago

I am not against this, but before starting to implement this, could you list the benefits of this over Cbor.

Parse packet from other mod or lib.

jakobkmar commented 1 year ago

I guess we could add a quick implementation (requiring opt-in) which uses the Silk nbt serialization and then writes the nbt to the packet (mojang already has a translation there) until we implement serialization to PacketByteBufs directly and make the API stable.