silk-game: Fix sideboards for 1.19.4

SilkMC / silk

Silk is a Minecraft API for Kotlin - targetting Fabric, Quilt and Paper

https://silkmc.net/silk/docs/

GNU General Public License v3.0

100 stars 12 forks source link

Closed Krxwallo closed 1 year ago

Krxwallo commented 1 year ago

This PR fixes the following things related to the sideboard api:

sideboard.hideFromPlayer() now actually calls the internal scoreboard.hideFromPlayer() method instead of calling the scoreboard.displayToPlayer() method again.
The matching score number is sent with the init packet, thereby fixing the issues in 1.19.4 with the order of the displayed sideboard lines.

grafik grafik

jakobkmar commented 1 year ago

Thanks for the fix, I am still a bit confused why the ordering worked with scores of zero before 1.19.4 though.