SillyTavern / SillyTavern-Extras

Extensions API for SillyTavern.
GNU Affero General Public License v3.0
563 stars 133 forks source link

Talkinghead next3 #214

Closed Technologicat closed 10 months ago

Technologicat commented 10 months ago
Technologicat commented 10 months ago

Also:

It has always had two morph targets in THA3 (left and right), but the JSON has only had one "eye_unimpressed" key.

This is technically a breaking change, but prior to the version of talkinghead being developed [in this series of PRs], the emotion JSON file format was not part of any public API. There was just a bunch of ready-made templates that were used internally by the live plugin. However, now that we have a working manual poser [and especially since I'm going to make the emotion templates configurable per-character], we can assume that from the next release on, emotion JSON files will exist in the wild.

Therefore, I propose to fix this now (as in commit https://github.com/SillyTavern/SillyTavern-Extras/pull/214/commits/a794ad9dde5517e66fd64901dc503209568d718e), and only consider the emotion JSON file format part of the public API from the next release onward.

Technologicat commented 10 months ago

Added one more fix - forgot about the per-frame probability trigger in the blink animation. Oops. Now that's scaled properly, too.

@Cohee1207: Now this PR is final, any upcoming changes will go into a new branch. Comments?

Cohee1207 commented 10 months ago

Nice, good work. Appreciate the math-heavy comment on the FPS algorithm.

Technologicat commented 10 months ago

Nice, good work. Appreciate the math-heavy comment on the FPS algorithm.

Just my usual approach when writing numerical solvers. This time the math was really easy, though, and we got a simple analytical solution :P

Thanks for the merge!