Characters in groupchat are outputting the prompt text with their own name in all fields

SillyTavern / SillyTavern-Extras

Extensions API for SillyTavern.

GNU Affero General Public License v3.0

547 stars 123 forks source link

Characters in groupchat are outputting the prompt text with their own name in all fields #4

Closed ClayShoaf closed 1 year ago

ClayShoaf commented 1 year ago

Instead of having:

Person1: Hello
Person2: Hey! How are you?
Person1: I'm doing great!
Person2: That's great!

When the prompt text comes up in the terminal, if Person1 is talking, it looks like

Person1: Hello
Person1: Hey! How are you?
Person1: I'm doing great!
Person1: That's great!

If Person2 is talking, it looks like

Person2: Hello
Person2: Hey! How are you?
Person2: I'm doing great!
Person2: That's great!

This basically makes it impossible for two characters to have a conversation with eachother.

Cohee1207 commented 1 year ago

@ClayShoaf what is the API and branch you're using?

Cohee1207 commented 1 year ago

Never mind, I see the issue now.

Cohee1207 commented 1 year ago

Fixed here for OpenAI: https://github.com/SillyLossy/TavernAI/commit/f14a1cb7e9bd56070e643381d176aa03579f730f

ClayShoaf commented 1 year ago

Unfortunately, it's still happening. The dev branch UI is pretty cozy though.

Cohee1207 commented 1 year ago

@ClayShoaf okay, here's one for non-OpenAI. I asked because the generational strategies are slightly varying on different AIs. https://github.com/SillyLossy/TavernAI/commit/eeb6a281d94e8c38fcec0603efe9c8e8621173d4

ClayShoaf commented 1 year ago

what is the API and branch you're using?

Whoops. I totally missed this question. Sorry about that. I'm using the KoboldAI API (via oobabooga's --extensions api flag). I tried using the "Text generation web UI" mode in TavernAI, but that wasn't working for me for some reason. I might have been doing something wrong, but using KolboldAI with oobabooga seems to be working fine. Thank you for all of your hard work!

ClayShoaf commented 1 year ago

Working like a charm now! Thank you so much! Random side question for you, do you know if there is any way to manually decide who speaks next other than going through the menu and changing the chatiness sliders up and down? I know if there isn't that it would be a complex task to add, so I'm not gonna request it, but I was just curious if something like that was already in place and I just missed it.

Cohee1207 commented 1 year ago

There's a way. Just mention the character's name in your message to make it speak.

ClayShoaf commented 1 year ago

Ah, I was afraid of that. I've been getting a kick out of letting the bots talk to each other without any input from me. No worries, I'll just keep doing it with the sliders and deleting messages as necessary. Maybe I'll try to hack around with it if I get too frustrated. Thanks again for all the work you've done on this!