SillyTavern / SillyTavern-Launcher

Launcher scripts for SillyTavern and ST-Extras.
MIT License
208 stars 56 forks source link

-extras installer: conda, python, pip, OpenSUSE package installer #23

Open ParaplegicRacehorse opened 11 months ago

ParaplegicRacehorse commented 11 months ago

The installer does not check for version conflicts when attempting to install miniconda.

At time of writing, the current release of miniconda requires Python v3.11.5. The miniconda website has installers for python3 versions older than v3.11.5. On Ubuntu LTS 22.04, for example, the latest python3 package is v3.10.12. A python3.11 package (binary called with python3.11) is v3.11.0rc1. Lots of other distros in the wild also don't have near-bleeding-edge Python in their repositories.

Unless you're planning to automate the process of version checking and installing the matching miniconda, the script should fail gracefully with a nice friendly notice that it doesn't know how to install miniconda on user's system and would user please go read the -extras README for instructions on how to manually install, with particular attention to visiting the miniconda website to learn about system requirements and download a miniconda installer that will work with user's system.


Also, pip should probably be called as pip3 to avoid calling the python2 pip where python2 may still exist alongside python3. Dunno about other distros, but pip3 exists on Debian/Ubuntu, Fedora, OpenSUSE, Arch.


Also, OpenSUSE packager zypper is not supported at all. zypper install [packagename] or zypper in [packagename]

ParaplegicRacehorse commented 11 months ago

Hmm. Actually, it might be interesting to check if Docker or Podman are installed and do a --build (or pull a prebuilt registry image) instead of screwing around with python and miniconda.

deffcolony commented 10 months ago

@ParaplegicRacehorse i changed pip to pip3 and added support for OpenSUSE packager zypper. so you can already update now but i still need to look at the version conflicts part