[BUG] Substitute regex bug

[soboruB]

Environment

🪟 Windows

System

Firefox

Version

1.12.7 staging

Desktop Information

No response

Describe the problem

When using substitute within regex, it matches the literal characters.

Example QR:

/setvar key=regex .* |
/setvar key=regexflags ims |
/setvar key=toreplace TEST |

Regex:

Additional info

I noticed a pull requests from 3 weeks ago titled 'Fix substitute regex'. This seems to be the cause of the issue. Please revert this change. It's an unwanted feature…

Please tick the boxes

• [X] I have explained the issue clearly, and I included all relevant info
• [X] I have checked that this issue hasn't already been raised
• [X] I have checked the docs

[Cohee1207]

@honey-tree fight

[Cohee1207]

Alternatively, "substitute regex" could be made a three-state select: no substitutions, substitute (raw), substitute (escaped).

[honey-tree]

I maintain that my implementation is objectively correct because it bare minimum ensures the regexes outputted are valid for arbitrary {{char}} and generic macro outputs etc.

I am surprised that this actually breaks things for someone. Radio with 3 options sounds good yeah.

[honey-tree]

Actually DOES IT break things for someone? Can you give us the broad strokes on the actual usecase that led you to notice the change in behavior?

EDIT: on my end, the issue was primarily that variables with newlines produce incoherent regexes, and secondarily "/{{char}}/ should reliably match {{char}}", hence the PR.

[Cohee1207]

Check this one #3105

[honey-tree]

Away from my computer and can't test it but seems reasonable to me.

[Cohee1207]

I'll wait for someone to test it then.

[soboruB]

I tested substitute(raw) and everything worked well as before. Thanks!

[Cohee1207]

@honey-tree lemme know if escaped substitution broke. Closing for now.