SiloCityLabs / lochnas

Docker configuration for all-in-one nas setup
https://lochnas.com
GNU General Public License v3.0
50 stars 3 forks source link

Pi support certbot #33

Open ldrrp opened 2 years ago

ldrrp commented 2 years ago

Problem

When running any of the domain renew/add/delete commands it calls certbot container which is currently set to latest tag. This will fail on raspberry pi or other arm based devices.

Solution

We need to detect the architecture and set the tag to arm/arm64/latest. This should be a variable thats shared between all 3 commands with a switch statement triggering the correct tag. Can be done in the init function if one exists for domain model.

Steps to Reproduce the Problem

  1. ./server.bin -domain renew
  2. ./server.bin -domain add domain.com
  3. ./server.bin -domain delete
ldrrp commented 2 years ago

Im actually not sure what happens since we dont use the "latest" tag, I wonder what docker does when its a different arch. Im going to push this to a future milestone since there is no way for me to test this atm since i have no pi.