search

Silvanite / novatoolpermissions

Laravel Nova Permissions Tool (User, Roles and Permissions / Access Control (ACL))
MIT License
101 stars 33 forks source link

remove viewNova from default permissions #19

Closed raftalks closed 5 years ago

raftalks commented 6 years ago

I would recommend to remove the viewNova gate definition from the package, considering the case where if every user do have access to viewNova and roles shouldn't give anyone to configure that permission.

this package is great and should only provide a default set of gate definitions relevant to the package resource and let the developers set their own gates for user resource etc.

solution: define only the following default permissions

{  "viewRoles": "View Roles",
    "manageRoles": "Manage Roles",
    "assignRoles": "Assign Roles",
}
m2de commented 6 years ago

Hi. Thanks for your report. In theory you can just leave the default gate method in place to achieve what you want. The only issue then is that the View Nova permission will appear in the UI but not actually do anything. That is much easier to resolve though.