User Resource hardcoded class issue

Silvanite / novatoolpermissions

Laravel Nova Permissions Tool (User, Roles and Permissions / Access Control (ACL))

MIT License

101 stars 33 forks source link

User Resource hardcoded class issue #2

Closed thierry2015 closed 6 years ago

thierry2015 commented 6 years ago

As a developer, I want to be able to use the Silvanite/novatoolpermissions package without relying on the basic Nova architecture.

Currently, in Silvanite\NovaToolPermissions\Role, the Nova User Resource class is hardcoded, which prevent the developer to change the basic architecture.

Proposed solution: use configuration file to retrieve the project-specific class

m2de commented 6 years ago

I believe this is now resolved after merging and publishing your PR #3 ? Thanks again for your contribution!

thierry2015 commented 6 years ago

Just tested it through a composer installation, this feature is correctly working and can be marked as completed, thanks for accepting my PR!