search

Silvenga / vscode-edi-x12-support

A Visual Studio Code extension aimed at providing basic support for the EDI format.
MIT License
31 stars 14 forks source link

Valid edi-x12 file but formatting fails with no ISA found #13

Closed jmfrank63 closed 5 years ago

jmfrank63 commented 5 years ago

I attached the file (renamed to .txt) as it is. Manually replacing ~ with ~\n works.

RA0219798_T_NUFACTOR_856_BP899883663_20190917065901.X12.txt

The extension is really cool, but kind of cumbersome without formatting ;-)

Silvenga commented 5 years ago

ISA11 defines the repeating element separator. Since that's a 'U' here, the parsing engine thinks that ISA08 is only 11 characters (which is invalid) during a self-check.

It looks like X12 00402 is the first version where a repeating separator exists. Can you confirm (I have no knowledge of 00401)?

Silvenga commented 5 years ago

In any case, should be handled in 1.1.0.

jmfrank63 commented 5 years ago

Hi Mark,

thanks for looking into this. I am rather new to X12 and EDI and your plugin is very helpful for me. I will try to contact our long time specialist on the version but cannot promise anything.

Thank you for providing this awesome plugin nevertheless.

Cheers

Johannes

On Sat, Sep 21, 2019 at 2:38 AM Mark Lopez notifications@github.com wrote:

In any case, should be handled in 1.1.0.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Silvenga/vscode-edi-x12-support/issues/13?email_source=notifications&email_token=AAXSQHQNOUVCUBRLHUFRWZTQKV3K7A5CNFSM4IYVNPK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IH3BQ#issuecomment-533757318, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXSQHWZUTAZZT3UP3XBKU3QKV3K7ANCNFSM4IYVNPKQ .

Silvenga commented 5 years ago

Thanks @jmfrank63 - and let me know if the 1.1.0 fixes your issue. Feel free to re-open this issue if it doesn't.